Skip to content

fix(test): set PartitionDiscoveryIntervalMs in the consumer integration subscription - #541

Merged
behinddwalls merged 2 commits into
mainfrom
chenghan.ying/fix-consumer-partition-discovery-interval
Aug 7, 2026
Merged

fix(test): set PartitionDiscoveryIntervalMs in the consumer integration subscription#541
behinddwalls merged 2 commits into
mainfrom
chenghan.ying/fix-consumer-partition-discovery-interval

Conversation

@roychying

@roychying roychying commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

#528 added SubscriptionConfig.PartitionDiscoveryIntervalMs and updated the call sites in test/integration/extension/messagequeue/mysql/queue_test.go, but missed the hand-built SubscriptionConfig literal in the consumer integration suite. The field stays 0, so managePartitions calls:

  time.NewTicker(time.Duration(cfg.PartitionDiscoveryIntervalMs) * time.Millisecond)

which panics with non-positive interval for NewTicker (platform/extension/messagequeue/mysql/subscriber.go:490). The subscriber goroutine dies and the test hangs until the 300s timeout.

Test Plan

Issue

…on subscription

Without it the field defaults to 0 and managePartitions panics on
time.NewTicker(0), hanging the test until the 300s timeout. #528 added
the field and updated the messagequeue integration tests, but missed
this hand-built SubscriptionConfig.
@roychying
roychying requested review from a team, behinddwalls and sbalabanov as code owners August 7, 2026 00:35
@behinddwalls
behinddwalls added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 0c6fcaa Aug 7, 2026
15 checks passed
@behinddwalls
behinddwalls deleted the chenghan.ying/fix-consumer-partition-discovery-interval branch August 7, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants